diff options
| author | Simon Glass <sjg@chromium.org> | 2011-12-20 15:53:20 -0800 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2011-12-20 17:17:14 -0800 |
| commit | 4bb9fddcf0c366008c276aee8a08590dc85ea83d (patch) | |
| tree | a19ebd5819a139e19b13b8d00792f829ba06920b /include | |
| parent | a3e0bc8e4e66da7119bf954b1747f70c92e1466b (diff) | |
Revert "Security: Make sure not to overflow the in memory version of the GBB"
This breaks recovery mode on Kaen - the bitmaps are not displayed.
This reverts commit e1153e1f56ebebff188f3693e534f10bd68e6f07
Change-Id: I300ae39382dc1960bb0375ad660a88b65181edc9
Reviewed-on: https://gerrit.chromium.org/gerrit/13274
Reviewed-by: Gabe Black (Do Not Use) <gabeblack@google.com>
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/chromeos/gbb.h | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/include/chromeos/gbb.h b/include/chromeos/gbb.h index d3770f51b1..c3bc304b38 100644 --- a/include/chromeos/gbb.h +++ b/include/chromeos/gbb.h @@ -22,11 +22,9 @@ * @param gbb Buffer for holding GBB * @param file Flashrom device handle * @param gbb_offset Offset of GBB in flashrom device - * @param gbb_size Size of the buffer holding GBB * @return zero if this succeeds, non-zero if this fails */ -int gbb_init(read_buf_type gbb, firmware_storage_t *file, uint32_t gbb_offset, - size_t gbb_size); +int gbb_init(read_buf_type gbb, firmware_storage_t *file, uint32_t gbb_offset); #ifndef CONFIG_HARDWARE_MAPPED_SPI /** @@ -35,11 +33,10 @@ int gbb_init(read_buf_type gbb, firmware_storage_t *file, uint32_t gbb_offset, * @param gbb Buffer for holding GBB * @param file Flashrom device handle * @param gbb_offset Offset of GBB in flashrom device - * @param gbb_size Size of the buffer holding GBB * @return zero if this succeeds, non-zero if this fails */ -int gbb_read_bmp_block(read_buf_type gbb, firmware_storage_t *file, - uint32_t gbb_offset, size_t gbb_size); +int gbb_read_bmp_block(read_buf_type gbb, + firmware_storage_t *file, uint32_t gbb_offset); /* * This loads the recovery key of GBB from flashrom. @@ -47,11 +44,10 @@ int gbb_read_bmp_block(read_buf_type gbb, firmware_storage_t *file, * @param gbb Buffer for holding GBB * @param file Flashrom device handle * @param gbb_offset Offset of GBB in flashrom device - * @param gbb_size Size of the buffer holding GBB * @return zero if this succeeds, non-zero if this fails */ -int gbb_read_recovery_key(read_buf_type gbb, firmware_storage_t *file, - uint32_t gbb_offset, size_t gbb_size); +int gbb_read_recovery_key(read_buf_type gbb, + firmware_storage_t *file, uint32_t gbb_offset); #else |