summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2020-05-26 14:29:02 -0400
committerTom Rini <trini@konsulko.com>2020-06-04 18:10:02 -0400
commitf3e2ebede3019740ee90471acc0a29a684b59221 (patch)
tree047f05ad2648c4b88ff5e02187e92a9e7835e8ae /scripts
parentdd5b0fad8f295c6e786f1528d09f03fa546289cd (diff)
checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files
All of our cmds have a Kconfig entry. Making enabling a CMD via the config file an error to checkpatch.pl. Signed-off-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/checkpatch.pl6
1 files changed, 6 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 17d41825c5..edba365651 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2267,6 +2267,12 @@ sub u_boot_line {
WARN("PREFER_IF",
"Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible\n" . $herecurr);
}
+
+ # use defconfig to manage CONFIG_CMD options
+ if ($line =~ /\+\s*#\s*(define|undef)\s+(CONFIG_CMD\w*)\b/) {
+ ERROR("DEFINE_CONFIG_CMD",
+ "All commands are managed by Kconfig\n" . $herecurr);
+ }
}
sub process {