summaryrefslogtreecommitdiff
path: root/snapshot.commit
diff options
context:
space:
mode:
authorStefan Brüns <stefan.bruens@rwth-aachen.de>2016-10-09 22:17:07 +0200
committerAlexander Graf <agraf@suse.de>2016-10-18 09:08:07 +0200
commitbdf5c1b3607bd6384ac5319caad2d8107130ace1 (patch)
treed7b697cd146911f5e717e9db6fa75a21de9d762c /snapshot.commit
parent852efbf5bd3047b12c1926564d792a7a1cea9eac (diff)
efi_loader: Fix memory map size check to avoid out-of-bounds access
The current efi_get_memory_map() function overwrites the map_size property before reading its value. That way the sanity check whether our memory map fits into the given array always succeeds, potentially overwriting arbitrary payload memory. This patch moves the property update write after its sanity check, so that the check actually verifies the correct value. So far this has not triggered any known bugs, but we're better off safe than sorry. If the buffer is to small, the returned memory_map_size indicates the required size to the caller. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Reviewed-by: Alexander Graf <agraf@suse.de> Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'snapshot.commit')
0 files changed, 0 insertions, 0 deletions