summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorMax Krummenacher <max.krummenacher@toradex.com>2015-10-29 15:00:21 +0100
committerPhilippe Schenker <philippe.schenker@toradex.com>2019-05-24 11:34:14 +0200
commit2398e44451cb4017176a2e6f8ce49496553618c7 (patch)
treea7061ae50a498b47bf00a8ce79f306579df44cc9 /drivers
parent1c87838b7884d575d26cfed9b4aa32dd25b94df9 (diff)
max9526.c: move pinctrl after i2c detect
This removes a bunch of error messages during probe because both the adv7180 and the max9526 use try to reserve the same pins. While at it convert debug output to dev_dbg Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> (cherry picked from commit a21e19829c50d9889a83faf00fc93be174314cdb) (cherry picked from commit 4e1e8d23e0ba899fceb3880b640c99496242af18)
Diffstat (limited to 'drivers')
-rw-r--r--drivers/media/platform/mxc/capture/max9526.c28
1 files changed, 14 insertions, 14 deletions
diff --git a/drivers/media/platform/mxc/capture/max9526.c b/drivers/media/platform/mxc/capture/max9526.c
index 6f6ed9559949..06242b727ca2 100644
--- a/drivers/media/platform/mxc/capture/max9526.c
+++ b/drivers/media/platform/mxc/capture/max9526.c
@@ -987,20 +987,7 @@ static int max9526_probe(struct i2c_client *client,
struct pinctrl *pinctrl;
struct device *dev = &client->dev;
- printk(KERN_ERR"DBG sensor data is at %p\n", &max9526_data);
-
- /* MAX9526 pinctrl */
- pinctrl = devm_pinctrl_get_select_default(dev);
- if (IS_ERR(pinctrl)) {
- dev_err(dev, "setup pinctrl failed\n");
- return PTR_ERR(pinctrl);
- }
-
- max9526_regulator_enable(dev);
-
- max9526_power_down(0);
-
- msleep(1);
+ dev_dbg(dev, "%s sensor data is at %p\n", __func__, &max9526_data);
/* Set initial values for the sensor struct. */
memset(&max9526_data, 0, sizeof(max9526_data));
@@ -1063,6 +1050,19 @@ static int max9526_probe(struct i2c_client *client,
}
}
+ /* MAX9526 pinctrl */
+ pinctrl = devm_pinctrl_get_select_default(dev);
+ if (IS_ERR(pinctrl)) {
+ dev_err(dev, "setup pinctrl failed\n");
+ return PTR_ERR(pinctrl);
+ }
+
+ max9526_regulator_enable(dev);
+
+ max9526_power_down(0);
+
+ msleep(1);
+
/*! MAX9526 initialization. */
max9526_hard_reset();